Database errors on installation not shown

Sat, 11/21/2009 - 18:04 — SaWey
My issue votes
0
votes
0/20 total votes used
Project:Kaltura Community Edition (CE) - Self Hosted Online Video Platform
Version:partnerServices3
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:patch (code needs review)
Total votes:3
Description

Hi,

I think I spotted an error in 'install.php' when the installer writes to the db in 'inject_db_content()'.
At line 209 there is this statement:

if (!$failed_queries){
    return '<div class="install failed">An error occured while trying to import DB.<br />Failed on the following queries:<br /> '.$failed_queries.' <br />Please make sure that your MySql server is up, and run that query manually</div>';
  }

Shouldn't this be

if ($failed_queries != ''){
    return '<div class="install failed">An error occured while trying to import DB.<br />Failed on the following queries:<br /> '.$failed_queries.' <br />Please make sure that your MySql server is up, and run that query manually</div>';
  }

Or something like this.

I spotted this because I have problems getting the install to finish, looked through the install log and saw a bunch of sql errors.

Hope this helps.

Comments

#1

Tue, 07/06/2010 - 04:48 — xurizaemon

I observed this issue on installation of KalturaCE today as well.

--
www.giantrobot.co.nz * http://twitter.com/grobot

#2

Mon, 07/12/2010 - 02:30 — xurizaemon

Patch at http://www.kaltura.org/kalturace-installer-miscalculates-server-root includes this fix (and another issue with the installer).

--
www.giantrobot.co.nz * http://twitter.com/grobot