kaltura_playlist_format_value should call a theme instead of module_invoke_all

1 reply [Last post]

Wed, 06/24/2009 - 15:56

Joined: 06/04/2009

Points: 22

Hi Kalturanians,

I was digging in the code and I realized that the function kaltura_playlist.module:kaltura_playlist_format_value() invokes "module_invoke_all" for customizing the output fields of the view that is used with the playlist.

I think it would be more "drupal friendly" if we use the theme system for that.

Besides, looking at this function:

function kaltura_playlist_invoke($hook) {

  $args = func_get_args();

  array_shift($args); // remove $hook

  $hook = 'kaltura_playlist_'. $hook;

  $return = module_invoke_all($hook, $data);

  return $return;

}

I think there is a bug, because $data comes from nowhere, I think it would be "$args" instead of "$data".

I'm looking forward to you reply!, thanks!