kaltura_playlist_format_value should call a theme instead of module_invoke_all

Thu, 07/09/2009 - 12:43 — yonailo
My issue votes
0
votes
0/20 total votes used
Project:Video & Media Module for Drupal
Component:Code
Category:bug report
Priority:minor
Assigned:Gonen.Radai
Status:active
Total votes:2
Description

Hi Kalturanians,

I was digging in the code and I realized that the function kaltura_playlist.module:kaltura_playlist_format_value() invokes "module_invoke_all" for customizing the output fields of the view that is used with the playlist.

I think it would be more "drupal friendly" if we use the theme system for that.

Besides, looking at this function:

      function kaltura_playlist_invoke($hook) {
        $args = func_get_args();
        array_shift($args); // remove $hook
        $hook = 'kaltura_playlist_'. $hook;
        $return = module_invoke_all($hook, $data);
        return $return;
      }

I think there is a bug, because $data comes from nowhere, I think it would be "$args" instead of "$data".

Original post: http://www.kaltura.org/kalturaplaylistformatvalue-should-call-theme-inst...

Comments

#1

Thu, 07/09/2009 - 13:21 — Kalturian
Assigned to:Anonymous» Gonen.Radai